OY-4699 API and functionality for updating all form koodisto values #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalamaGofore
approved these changes
Mar 8, 2024
| (let [form (form-store/fetch-by-key form-key) | ||
| has-applications? (form-store/form-has-applications form-key) | ||
| updated-form (koodisto/populate-form-koodisto-fields koodisto-cache form true)] | ||
| (when has-applications? (throw (user-feedback-exception (str "Lomakkeella " (:key form) " on hakemuksia.")))) |
There was a problem hiding this comment.
tän vois varmaan tehdä jo ennen tota lettiä?
tarjonta-service:stä pitäisi saada haun tiedot ja löytyy myös koodia missä niitä hakuaikoja tarkastellaan, jos haluaa senkin implementoida tähän.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API and service code to update all code sets to latest ones in a single form - creating a new version of the form with same key.
Adds and removes values if necessary, updates labels. Fails in case any followups would be erased accidentally, or if there are any applications submitted already.
(Bonus points: might be worth it to check if the application period has already been started even if no applications have been submitted yet, to avoid possible issues with last minute fixes, but couldn't find an easy mechanism for that, so maybe this will serve as a Minimum Viable Feature...)