-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yet more image minification #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess one of the kernel updates has changed the control numbers, breaking the vario sound. This way of specifying the ALSA mixer state is rather fragile... Closes #273
kedder
approved these changes
Feb 17, 2022
This prevents those daemons from writing to the file "/sensord.log" and "/variod.log", which is a rather bad location for a log file. And it switches to "Type=simple" (systemd's default); "Type=forking" forces systemd to chase after the daemonized process, which is inherently unreliable.
Follows the convention used by Yocto.
Just in case OpenVario one day wants to suport a different board one day.
alsactl wants to create /run/lock/asound.state.lock, and systemd creates /run/lock only if legacy sysv support is enabled (which OpenVario does not). Closes #273
Shrinks the "megadriver" by 800 kB.
linuxianer99
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Down to 71 MB rootfs, 33 MB compressed image.