fix(robot-server): Use wsproto instead of websockets #6229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitlissack
added
fix
amitlissack
requested review from
mcous and
sanni-t
and removed request for
a team
sfoster1
approved these changes
Jul 28, 2020
sfoster1
approved these changes
Jul 28, 2020
mcous
approved these changes
Jul 28, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Websockets does not support uploads larger than 1mb. Uvicorn supports
wsprotowhich can handle unlimited size.Changelog
Include wsproto in Pipfile and Config.in.
Add
--ws wsprototo uvicorn command lineReview requests
Using runapp load json protocol file in #6159. It should load and simulate.
Risk assessment
Minimal. Different websockets library.
closes #6159