fix(app-shell): fix electron-updater failures #17056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #17010, we lifted
electron-updater
out of severalpackage.json
s into the monorepopackage.json
. So yeah...electron-builder
builds using the siblingpackage.json
, because of course, it can't really know what else it needs to pull into the build from any otherpackage.json
. Woops.This PR effectively reverts that one commit in the linked PR.
Test Plan and Hands on Testing
make -C app-shell dist-macos-latest
). The build will still fail due to key signing, but the build will actually run.Changelog
Risk assessment
low