fix(protocol-designer): add duplicate tipracks off deck #17026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Dec 3, 2024
| (selectedNestedLabwareDefUri != null && | ||
| selectedNestedLabwareDefUri !== | ||
| createdNestedLabwareForSlot?.labwareDefURI)) | ||
| (slot === 'offDeck' && selectedLabwareDefUri != null) || |
There was a problem hiding this comment.
definitely need to clean up this component after the release. the logic is confusing to follow!
ncdiehl11
reviewed
Dec 3, 2024
ncdiehl11
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3744
Overview
Fix bug where you couldn't add the same tiprack multiple times off deck
Test Plan and Hands on Testing
Test that you can add multiple of the same labware and tipracks offdeck by selecting it and not pressing the duplicate button
Changelog
Risk assessment
low