Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(step-generation): fix blowout location from multi-dispense disposal #17013

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 3, 2024

closes RESC-356

Overview

When the blowout Z tip position field for multi dispense diposal was introduced to PD in the 8.1.0 release, we never tested that it actually worked correctly I guess. The bug outlined in the ticket shows that the customer set their blowout tip position to -20mm from the top of the well in multi-dispense diposal but when running their protocol, the blowout still occurred at the top of the well.

The fix was to modify the logic in which the blowoutOffsetFromTopMm was set in moveLiquidFormToArgs. With the blowout Z position field introduced to the multi-dispense disposal section, blowoutLocation was always being null because it required the user to select the blowout checkbox outside of the disposal section. This PR fixes that by also searching for if the disposal fields and blowout location are filled out.

Test Plan and Hands on Testing

Upload the attached protocol and search for the blowout commands with a position of -20 for the z value. See that it doesn't exist. Then upload it to PD and then export and look at the protocol again, the blowout commands with a position -20 for the z value should exist now.

qPCR Plating_v1_with Multi dispense_optimization.json

Changelog

Review requests

Risk assessment

low

@jerader jerader requested a review from a team as a code owner December 3, 2024 15:11
@jerader jerader requested a review from ncdiehl11 December 3, 2024 15:11
@jerader jerader changed the base branch from edge to chore_release-pd-8.2.0 December 3, 2024 15:11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit 3821594 into chore_release-pd-8.2.0 Dec 3, 2024
24 checks passed
@jerader jerader deleted the sg_disposal-blowout branch December 3, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants