fix(step-generation): fix blowout location from multi-dispense disposal #17013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RESC-356
Overview
When the blowout Z tip position field for multi dispense diposal was introduced to PD in the 8.1.0 release, we never tested that it actually worked correctly I guess. The bug outlined in the ticket shows that the customer set their blowout tip position to -20mm from the top of the well in multi-dispense diposal but when running their protocol, the blowout still occurred at the top of the well.
The fix was to modify the logic in which the
blowoutOffsetFromTopMm
was set inmoveLiquidFormToArgs
. With the blowout Z position field introduced to the multi-dispense disposal section,blowoutLocation
was always being null because it required the user to select the blowout checkbox outside of the disposal section. This PR fixes that by also searching for if the disposal fields and blowout location are filled out.Test Plan and Hands on Testing
Upload the attached protocol and search for the blowout commands with a position of -20 for the z value. See that it doesn't exist. Then upload it to PD and then export and look at the protocol again, the blowout commands with a position -20 for the z value should exist now.
qPCR Plating_v1_with Multi dispense_optimization.json
Changelog
Review requests
Risk assessment
low