fix(protocol-designer): various select pipette bug in onboarding flow #17001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like the editing the instruments on the overview page works a bit differently and logic seems to be working to me ⭐ |
|
the back button works but when removing 2 pipettes, confirm button is clickable. steps
|
koji
reviewed
Dec 2, 2024
Comment on lines
116
to
118
| page === 'add' && | ||
| pipettesByMount[defaultMount].tiprackDefURI == null && | ||
| noPipette |
There was a problem hiding this comment.
for the attached screenshot case
Suggested change
| page === 'add' && | |
| pipettesByMount[defaultMount].tiprackDefURI == null && | |
| noPipette | |
| const isDisabled = | |
| (page === 'add' && | |
| pipettesByMount[defaultMount].tiprackDefURI == null && | |
| noPipette) || | |
| selectedValues.length === 0 |
There was a problem hiding this comment.
this results in requiring to add a 2nd pipette when you go back to add a 2nd pipette. let me look into another option
There was a problem hiding this comment.
ok i think i found a way that works!
ncdiehl11
approved these changes
Dec 2, 2024
| (page === 'add' && | ||
| pipettesByMount[defaultMount].tiprackDefURI == null && | ||
| noPipette) || | ||
| (pipettesByMount.left.tiprackDefURI == null && |
There was a problem hiding this comment.
nit, maybe we could add a utility to get these values rather than checking both mounts. not necessary in this PR
| @@ -174,6 +166,16 @@ export function SelectPipettes(props: WizardTileProps): JSX.Element | null { | |||
| } | |||
| }, [location]) | |||
|
|
|||
| const hasAPipette = | |||
| (defaultMount === 'left' && pipettesByMount.right.pipetteName != null) || | |||
| @@ -76,7 +76,7 @@ export function SelectPipettes(props: WizardTileProps): JSX.Element | null { | |||
| const allowAllTipracks = useSelector(getAllowAllTipracks) | |||
| const allPipetteOptions = getAllPipetteNames('maxVolume', 'channels') | |||
| const robotType = fields.robotType | |||
| const defaultMount = mount ?? 'left' | |||
| const defaultMount = mount | |||
There was a problem hiding this comment.
no lol i can remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3721 RQA-3716
Overview
Fixes some bugs with the 96-channel option not showing up correctly
Fixes the copy for adding a 2nd pipette
fixes the ability to add a 2nd pipette but then proceed without completing
Test Plan and Hands on Testing
Test adding/removing/editing pipettes in the select pipette portion of the onboarding flow.
Changelog
Risk assessment
low