Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): delete unused code #16869

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 18, 2024

closes AUTH-645

Overview

We are free to merge this in since the PD release will be off of the release branch!

This PR deletes unused code and moves a few components into the correct folder (such as LabwareOnDeck, getUnusedEntities). There are also a few redux actions/selectors/reducers that were deleted because they are no longer in use. Those include:

  1. thermocycler profile step -> the redesign has it contained in a modal and keeps track of stuff via local states
  2. a bunch of hints -> we deprecated most of them for the redesign. only remaining hints are for exporting a protocol with unused hardware and changing your magnetic module version
  3. redux actions related to navigation -> we use react-router-dom now for navigation
  4. stuff related to expanding and collapsing steps and multi-steps -> we no longer allow expanding/collapsing steps at all

Additionally, all css style sheets are officially deleted 🗑️

Test Plan and Hands on Testing

Thoroughly smoke test locally.

Changelog

🗑️

Review requests

Risk assessment

medium? it deletes a bunch of code but it off of edge

@jerader jerader added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Nov 18, 2024
@jerader jerader changed the title start to delete unused code feat(protocol-designer): delete unused code pt1 Nov 18, 2024
@jerader jerader changed the title feat(protocol-designer): delete unused code pt1 feat(protocol-designer): delete unused code Nov 18, 2024
@jerader jerader force-pushed the pd_clean-unused-code branch from ffc2219 to b8188b0 Compare December 3, 2024 15:49
@jerader jerader added authorship and removed DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available labels Dec 3, 2024
@jerader jerader marked this pull request as ready for review December 3, 2024 15:59
@jerader jerader requested a review from a team as a code owner December 3, 2024 15:59
@jerader jerader requested review from koji and ncdiehl11 December 3, 2024 15:59
Copy link
Contributor

@ddcc4 ddcc4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stampstampstamp

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this!

@jerader jerader merged commit 84f9ba5 into edge Dec 4, 2024
14 checks passed
@jerader jerader deleted the pd_clean-unused-code branch December 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants