-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(robot-server): update data_files_table with uploaded source #16813
fix(robot-server): update data_files_table with uploaded source #16813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick investigation. This makes sense.
I think we must test this before merging. Ideally with an automated snapshot-based test, but manually works too for the sake of cutting the alpha. The old code was (apparently?) not covered by any test at all, so we don’t want to repeat that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this so quickly.
totally agree! I will test this manually for now but we need a test for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @SyntaxColoring re: testing, and thank you for fixing!
Agree on the testing, ill add a test to cover this case. |
Tested on my laptop with persistence directories extracted from a couple of ABR robots. (I've attached the .zips to the ticket.) The new migration completes successfully on both. I haven't checked if the new data is semantically correct and that you can use the files in runs, etc. |
Overview
bug fix for https://opentrons.atlassian.net/browse/RABR-665.
update db row instead of inserting
Test Plan and Hands on Testing
upgrade to the next alpha on ABR9 (10.14.19.41) and ABR12 (10.14.19.236) and make sure migration is complete.
Changelog
update sql instead of insert.
Review requests