fix(api): Skip updating position estimators for axes that are not present #16804
Conversation
|
|
||
| if axes: | ||
| checked_axes = [ax for ax in axes if ax in Axis] |
There was a problem hiding this comment.
[ax for ax in axes if ax in Axis] looked like a no-op to me. Was there a hidden intent to that, or was that just a small oversight?
There was a problem hiding this comment.
That’s for possibly filtering out things that aren’t axis enums. It might be holdover ot2 code where there’s chronic string/enum confusion
| detail={ | ||
| "missing-nodes": ", ".join( | ||
| node.name for node in set(nodes).difference(set(data)) | ||
| ) | ||
| }, | ||
| detail={"missing-node": node.name}, |
There was a problem hiding this comment.
When any node was missing, the error message here said that node, plus all the nodes that would have come after it, and that we didn't attempt. This narrows it down to just the node that actually timed out.
SyntaxColoring
requested review from
shlokamin
and removed request for
a team
|
|
||
| if axes: | ||
| checked_axes = [ax for ax in axes if ax in Axis] |
There was a problem hiding this comment.
That’s for possibly filtering out things that aren’t axis enums. It might be holdover ot2 code where there’s chronic string/enum confusion
Overview
Fixes RQA-3569.
Test Plan and Hands on Testing
unsafe/updatePositionEstimatorscommands should succeed.Changelog
prepareToAspiratecommand from the drop tip wizard. This was causing the wizard to fail with a "no tip attached" error. @mjhuff, @sfoster1 and I couldn't remember why we added it in the first place in fix(app): use a slow blowout in DTWiz #15869.Review requests
gripper_galways timed out, even with a gripper attached. Is that expected, or should we investigate further?prepareToAspiratecommand?Risk assessment
Medium. We're not so sure about the
prepareToAspiratecommand. If it breaks something, it'll probably break something somewhere in error recovery.