fix(app, components) fix csv name wrapping issue #16785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix csv name wrapping issue close RQA-3516
ncdiehl11
approved these changes
Nov 14, 2024
| } from '@opentrons/components' | ||
| import { useToaster } from '../../../ToasterOven' | ||
|
|
||
| const CSV_FILE_MAX_LENGTH = 15 |
There was a problem hiding this comment.
Is this arbitrary or recommended from design?
There was a problem hiding this comment.
I just counted the characters in the design.
https://www.figma.com/design/MlZjOO8aZXsw3HfTBoyw9U/Release%3A-CSV?node-id=2088-6307&m=dev
There was a problem hiding this comment.
oh, the max should be 18.
changed the max length. 15 chars + 3 dots. (3 chars)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix csv name wrapping issue
close RQA-3516
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low