Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): app signing secret rotation #16738

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Nov 8, 2024

Overview

Further fixes for app signing secrets rotation.

  • Windows build is successfully signed
  • MacOS build is successfully signed and notarized

@y3rsh y3rsh self-assigned this Nov 8, 2024
@y3rsh y3rsh requested a review from a team as a code owner November 8, 2024 00:22
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Whoops.

@y3rsh y3rsh merged commit cdb909e into edge Nov 8, 2024
19 checks passed
@y3rsh y3rsh deleted the signing-secrets-rotation-app-build-as-release branch November 8, 2024 14:18
y3rsh added a commit that referenced this pull request Nov 8, 2024
Further fixes for app signing secrets rotation.
y3rsh added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants