fix(app): add an exit button for failed moveToAddressable area commands during Error Recovery #16729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds during Error Recovery
mjhuff
requested review from
ncdiehl11
and removed request for
a team and
ncdiehl11
mjhuff
commented
Nov 7, 2024
Comment on lines
+46
to
+50
| setErrorDetails({ | ||
| header: header ?? t('cant_safely_drop_tips'), | ||
| message: messageText ?? t('remove_the_tips_manually'), | ||
| type, | ||
| }) |
There was a problem hiding this comment.
Added some fallback copy just in case.
|
"Return to menu" struck me as a little odd, but I see it's already in our localization strings, so carry on. |
mjhuff
force-pushed
the
app_add-drop-tip-exit-btn-recovery
branch
from
ce3664c to
5b40f90
Compare
smb2268
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3542
Overview
See the ticket for the steps to reproduce. The
moveToAddressableAreacommand did not have correct conditional logic in some spots for handling the error if it occurred during afixitflow. This PR refactors the command logic, so any error will be handled correctly if the flow isfixit.Also, recent fixes for unrendering pipette cards made it so that errors which occur during drop tip wizard during error recovery would automatically cancel the run instead of showing users the proper "error" modal, so that is fixed as well.
Current Behavior
Fixed Behavior
Test Plan and Hands on Testing
Changelog
Risk assessment
low