Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix run log TC lid stacking issues and module icon formatting #16705

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Nov 6, 2024

Overview

Adapt run log command text to account for the possibility of more than 2 labware existing in a stack when deriving labware location and fix display of module icon in LPC results modal

Test Plan and Hands on Testing

  1. Look at LPC results modal on ODD that has labware on modules, see that module icon now appears next to slot location
  2. Look at run log for protocol that loads multiple TC lids in a stack and then uses the gripper to move them around the deck. Locations should now be accurately reported
Screen Shot 2024-11-05 at 1 43 40 PM

Screen Shot 2024-11-06 at 11 54 32 AM

Changelog

  1. In getLabwareLocation add new case in which an labware stacked on top of another labware (previously only labware stacked on adapter) can have another labware stacked below it. Derive the bottommost slot location in a stack in this scenario instead of printing every item in the stack
  2. Use this getLabwareLocation util in getLoadCommandText instead of replicating logic
  3. Add flex display for slot and module icon in LPC results modal on ODD

Review requests

Code check on util update, look over screenshots

Risk assessment

Low

@smb2268 smb2268 requested a review from mjhuff November 6, 2024 17:00
@smb2268 smb2268 self-assigned this Nov 6, 2024
@smb2268 smb2268 requested a review from a team as a code owner November 6, 2024 17:00
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the i18n comments. Thanks for fixing!

app/src/assets/localization/en/protocol_command_text.json Outdated Show resolved Hide resolved
app/src/assets/localization/en/protocol_command_text.json Outdated Show resolved Hide resolved
@smb2268 smb2268 requested a review from CaseyBatten November 7, 2024 16:43
"load_labware_info_protocol_setup_no_module": "在{{slot_name}}号板位中加载{{labware}}",
"load_labware_info_protocol_setup_off_deck": "在甲板外加载{{labware}}",
"load_labware_info_protocol_setup_plural": "在{{module_name}}中加载{{labware}}",
"load_labware_info_protocol_setup": "在{{slot_name}}号板位中的{{module_name}}中加载{{labware}}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These strings don't exist in the english version

@smb2268 smb2268 merged commit e813161 into chore_release-8.2.0 Nov 7, 2024
35 checks passed
@smb2268 smb2268 deleted the app_tc-lid-run-log branch November 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants