Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, components): Fix TC lid rendering in runRecord deck maps #16692

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Nov 5, 2024

Closes EXEC-804

Overview

Deck maps that utilize the run record instead of protocol analysis render labware differently and generally behave "not like the other deck maps", so we need to make proper affordances for TC lids.

192352a - We recently created a getDisplayLocation util with the goal of centralizing copy generation for locations. We need to special-case handle labware in the TC slot, which is in slot "A1+B1".

c04ecdd - The MoveLabwareOnDeck deck hard codes the labware color to COLORS.white, which worked well until TC lids, which are orange. Looking at this component, it seems we can refactor this down significantly and get the correct behavior by just using LabwareRender. I think this is the case, but see test plan. This commit should also correct behavior when manually moving TC lids on the deck during a protocol run.

203249e - TC labware renders in B1 instead of the special TC location. In the ER deck map, we need an intermediate step to correct this behavior. It's not a great fix, but there's not too much of a point of improving deck map internals given the imminent redesign.

Current Behavior

Screenshot 2024-11-04 at 1 08 19 PM Screenshot 2024-11-05 at 9 08 25 AM

Fixed Behavior

Screenshot 2024-11-04 at 4 55 25 PM Screenshot 2024-11-05 at 9 46 47 AM

Test Plan and Hands on Testing

  • Ran a lot of Error Recovery flows, confirming correct deck map renderings.
  • Ran several runs of manual move labware protocols with different labware, ensuring correct deck map behavior (and color).

Changelog

  • Fixed display issues with thermocycler lids during protocol run deck maps.

Risk assessment

medium - This does touch both the manual move intervention deck map and the Error Recovery deck map

@mjhuff mjhuff requested a review from a team as a code owner November 5, 2024 17:40
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good!

@mjhuff mjhuff changed the title fix(app): Fix TC lid rendering in runRecord deck maps fix(app, components): Fix TC lid rendering in runRecord deck maps Nov 5, 2024
@mjhuff mjhuff merged commit de01cf6 into chore_release-8.2.0 Nov 5, 2024
44 checks passed
@mjhuff mjhuff deleted the app_fix-tc-deck-recovery branch November 5, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants