fix(app, components): Fix TC lid rendering in runRecord
deck maps
#16692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-804
Overview
Deck maps that utilize the run record instead of protocol analysis render labware differently and generally behave "not like the other deck maps", so we need to make proper affordances for TC lids.
192352a - We recently created a
getDisplayLocation
util with the goal of centralizing copy generation for locations. We need to special-case handle labware in the TC slot, which is in slot "A1+B1".c04ecdd - The
MoveLabwareOnDeck
deck hard codes the labware color toCOLORS.white
, which worked well until TC lids, which are orange. Looking at this component, it seems we can refactor this down significantly and get the correct behavior by just usingLabwareRender
. I think this is the case, but see test plan. This commit should also correct behavior when manually moving TC lids on the deck during a protocol run.203249e - TC labware renders in B1 instead of the special TC location. In the ER deck map, we need an intermediate step to correct this behavior. It's not a great fix, but there's not too much of a point of improving deck map internals given the imminent redesign.
Current Behavior
Fixed Behavior
Test Plan and Hands on Testing
Changelog
Risk assessment
medium - This does touch both the manual move intervention deck map and the Error Recovery deck map