-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): Absorbance Plate Reader in Python API docs #16668
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.2.0 #16668 +/- ##
====================================================
Coverage 92.43% 92.43%
====================================================
Files 77 77
Lines 1283 1283
====================================================
Hits 1186 1186
Misses 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. |
bc50c82
to
f19ef28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great, all the information regarding plate reader setup and use appears to be accurate to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added review comments for consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this; I think it's descriptive of the methods to use the plate reader and that users will appreciate the ways to use the data afterwards.
Added a few comments that are mostly clarifications based on questions that jumped into my (newbie) head while reading.
Overview
Adds a docs page and publishes API Reference entries for the Absorbance Plate Reader.
Addresses RTC-488, RTC-508.
Test Plan and Hands on Testing
Sandbox
Changelog
AbsorbanceReaderContext
docstrings inmodule_contexts.py
module_contexts.py
conf.py
now thatAbsorbanceReaderContext
is publishedReview requests
wavelengths
values that actually function on a default HW config?Risk assessment
v low, docs only