fix(app): Fix tip drop height during Error Recovery #16656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
commented
Oct 31, 2024
| ): CreateCommand => { | ||
| // Always ensure the user does all the jogging if choosing a custom location on the deck. | ||
| const stayAtHighestPossibleZ = !isPredefinedLocation |
There was a problem hiding this comment.
Note that we still must specify this param during Error Recovery, because if the client issues a moveToAddressableArea after selecting the "manually move to a location" option, the pipette will move in the z-axis, which we want to avoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3474
Overview
See #16636 for some background context (as well as what caused the regression). The conditional logic for utilizing the manual tip offset during Error Recovery was not quite right, as we were supplying
stayAtHighestPossibleZto themoveToAddressableAreacommand in all instances. This PR corrects it.Thanks @SyntaxColoring for the pairing!
Test Plan and Hands on Testing
Changelog
Risk assessment
low