fix(api): Fix certain failed runs showing a stale recovery target #16630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-503.
Test Plan and Hands on Testing
I think unit tests are sufficient here.
As far as I know, this bug no longer has any user-visible effect that we can test against. This is because the PAPI layer handles error recovery much more comprehensively now, so this part of EXEC-503's steps to reproduce can't happen in practice:
Changelog
The bug was that I added code to do the right thing in
StopAction
, but I neglected to add the same code inFinishAction
.When a run ends:
opentrons.protocol_engine
StopAction
, depending on the circumstances.opentrons.protocol_engine
FinishAction
.Review requests
None in particular.
Risk assessment
Low.