Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Fix certain failed runs showing a stale recovery target #16630

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Closes EXEC-503.

Test Plan and Hands on Testing

I think unit tests are sufficient here.

As far as I know, this bug no longer has any user-visible effect that we can test against. This is because the PAPI layer handles error recovery much more comprehensively now, so this part of EXEC-503's steps to reproduce can't happen in practice:

  1. The Python API naively lets the exception propagate, not taking advantage of the error’s recoverability

Changelog

The bug was that I added code to do the right thing in StopAction, but I neglected to add the same code in FinishAction.

When a run ends:

  • It sometimes, but not always, goes through an opentrons.protocol_engine StopAction, depending on the circumstances.
  • It's always goes through an opentrons.protocol_engine FinishAction.

Review requests

None in particular.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team October 29, 2024 19:04
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner October 29, 2024 19:04
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops lol

@SyntaxColoring SyntaxColoring merged commit b27a22c into edge Oct 29, 2024
27 checks passed
@SyntaxColoring SyntaxColoring deleted the clear_recovery_target_when_run_fails branch October 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants