Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): deck thumbnail reflects liquids at starting d… #16626

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Oct 29, 2024

…eck state

closes AUTH-816

Overview

the deck thumbnail should always reflect the deck state at the starting deck state. this fixes an issue where the liquids would get updated to a different state

Test Plan and Hands on Testing

Upload the attached protocol and go to protocol steps and click on the final deck state. see that the liquids and labware move on the deck map

then click "done" and go back to overview and see that the deckmap thumbnail shows everything, including liquids, at the starting deck state.

1.0 testing.json

Changelog

  • set terminal item to the initial setup when pressing done from the designer tab

Risk assessment

low

@jerader jerader requested a review from a team as a code owner October 29, 2024 16:05
@jerader jerader requested review from koji and ncdiehl11 October 29, 2024 16:05
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit 4530e4e into edge Oct 29, 2024
20 checks passed
@jerader jerader deleted the pd_deck-thumbnail-liquid-state branch October 29, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants