Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): set correct aws bucket region when deploying #16598

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Oct 24, 2024

Overview

For whatever reason when all of our aws buckets were moved around to different accounts the regions they live in changed. PD lives in 'us-east-1, and all of the others live in 'us-east-2

You must correctly specify the regions to successfully send aws commands.

Test Plan

I verified I could promote to staging for docs, PD, and LL

@shlokamin shlokamin marked this pull request as ready for review October 24, 2024 17:34
@shlokamin shlokamin requested a review from a team as a code owner October 24, 2024 17:34
@shlokamin shlokamin requested review from brenthagen, y3rsh, sfoster1 and jerader and removed request for a team October 24, 2024 17:34
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

us-east-2 and us-west-2 are commonly used if the feature is available in those regions instead of the rumored "older and crowded" us-east-1 and us-west-1.
No idea if this is true today but I always use us-east-2 if possible for everything we do.

@shlokamin shlokamin merged commit d454914 into edge Oct 24, 2024
18 checks passed
@shlokamin shlokamin deleted the scripts_update-aws-region branch October 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants