Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): change DEFAULT_SLOT_MAP_OT2 TC slot to be 7 instead of span7_8_10_11 #16585

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 23, 2024

Overview

change DEFAULT_SLOT_MAP_OT2 TC slot to be 7 instead of span7_8_10_11

close RQA-3419

Test Plan and Hands on Testing

  1. create an OT-2 protocol with TC Gen1
    TC Gen1 shows up in the deck view

  2. create an OT-2 protocol with TC Gen2
    TC Gen2 shows up in the deck view

Changelog

Review requests

Risk assessment

low

…nstead of span7_8_10_11

change DEFAULT_SLOT_MAP_OT2 TC slot to be 7 instead of span7_8_10_11

close RQA-3419
@koji koji requested review from ncdiehl11 and jerader October 23, 2024 21:20
@koji koji marked this pull request as ready for review October 23, 2024 21:21
@koji koji requested a review from a team as a code owner October 23, 2024 21:21
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for fixing!

@koji koji merged commit 5965706 into edge Oct 23, 2024
24 checks passed
@koji koji deleted the fix_RQA-3419 branch October 23, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants