refactor(app): Add move animations to manual gripper move during Error Recovery #16567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain keying by labwareId was not working correctly because we use the run command for a few things and protocol analysis for other things. To key by id properly, use the run record for everything.
mjhuff
requested review from
brenthagen
and removed request for
a team and
brenthagen
sfoster1
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3392
Overview
Per design, when manually moving labware during a gripper error recovery flow, we should show the labware moving instead of stationary in the initial slot . While there exists a move labware deck view, it does require some legwork to wire up the props necessary to render the component,
MoveLabwareOnDeck. There's room to makeMoveLabwareOnDeckbetter and not make use of utils internal to the component, see EXEC-788.e551948 - We need actual labware locations for
MoveLabwareOnDeck, since we're doing more than just rendering their display equivalent now.f8ed107 - Turns out we have another O(n) util that does almost the same thing as
getLabwareDefinitionsFromCommands, and it turns out we are also misusing it in the app. I've corrected the one misuse of this in Error Recovery. There's already a sustaining ticket for auditing our usage of these utils.19ad1d6 - Fixes a bug that's obvious when nesting labware on top of a module.
d6110fa - Wires up the new props to an appropriate deck map.
48ff3a0 - Tests, etc.
Screen.Recording.2024-10-22.at.1.21.06.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low