refactor(app): permit scrolling during ER & drop tip on desktop app #16558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3391
Overview
In cropped views of the desktop app, it's currently not possible to scroll. We should allow that. After some post-8.0 refactoring, I accidentally added this to ER/drop tip wiz in order to prevent wonky looking scrolling bars on the ODD, but we can just not show the bars on the ODD (since the ODD is always the same screen size).
Screen.Recording.2024-10-21.at.4.49.51.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low