refactor(app): update desktop RecoveryOptions #16528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-739
Overview
Part of the design unification work has entailed adding desktop support for
RadioButton. Per design, we'd like to use the new look in the SelectRecoveryOption view.Unfortunately, there's still some special casing logic that has to occur, because we need the 'desktop' border radius (PD uses both the ODD and desktop border radius styles, so we can't make a hard and fast style rule for the component). It might be worth extending
RadioGroupto some sort of app moleculeRadioGroupand enforce the border radius styling there, but it's probably worth talking to design before doing that.Risk assessment
low