refactor(app): Update ignore error route in Error Recovery #16511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
changed the title
mjhuff
force-pushed
the
app_refactor-ignore-route-error-recovery
branch
from
a28ddda to
5477f57
Compare
sfoster1
approved these changes
Oct 17, 2024
TamarZanzouri
pushed a commit
that referenced
this pull request
Oct 18, 2024
Partially closes EXEC-776 As the "ignore error and skip/retry" routing no longer applies only to one recovery option, it's worth revisiting the way we structure routing/copy. More importantly, we probably should avoid sending any sort of "ignore all errors" policy updates to the server until the user exits error recovery, because sending policy changes earlier could provide unexpected behavior if the user selects the "ignore all option" but then clicks "go back". If the PUT request for the policy updates fail, route the user to our "recovery failed" modal and let the user select a different (or same) option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes EXEC-776
Overview
As the "ignore error and skip/retry" routing no longer applies only to one recovery option, it's worth revisiting the way we structure routing/copy. More importantly, we probably should avoid sending any sort of "ignore all errors" policy updates to the server until the user exits error recovery, because sending policy changes earlier could provide unexpected behavior if the user selects the "ignore all option" but then clicks "go back".
If the
PUTrequest for the policy updates fail, route the user to our "recovery failed" modal and let the user select a different (or same) option.Screen.Recording.2024-10-17.at.12.48.56.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low