fix(protocol-designer): enable color picker's alpha value #16505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable color picker's alpha value close RQA-3347
ncdiehl11
requested changes
Oct 17, 2024
|
tested the code here |
ncdiehl11
approved these changes
Oct 18, 2024
| const rgbaToHex = (rgba: RGBColor): string => { | ||
| const { r, g, b, a } = rgba | ||
| const toHex = (n: number): string => n.toString(16).padStart(2, '0') | ||
| const alpha = a != null ? Math.round(a * 255) : 255 |
TamarZanzouri
pushed a commit
that referenced
this pull request
Oct 18, 2024
* fix(protocol-designer): enable color picker's alpha value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
enable color picker's alpha value since onChange used only rgb
color_picker_alpha.mov
close RQA-3347
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low