Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): move pipette movement conflict checks to separate file #16439

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Oct 8, 2024

Overview

Addresses a long-standing TODO to separate out the pipette movement conflict and deck-placement conflict code since they are completely exclusive of each other and don't need to be in the same file.

Changelog

  • moved all pipette movement conflict checking code to pipette_movement_conflict.py

Risk assessment

None. Refactor only

@sanni-t sanni-t marked this pull request as ready for review October 8, 2024 21:07
@sanni-t sanni-t requested a review from a team as a code owner October 8, 2024 21:07
@sanni-t sanni-t requested a review from CaseyBatten October 8, 2024 21:08
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.28%. Comparing base (5658b8a) to head (5212d3f).
Report is 298 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #16439   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         300      300           
  Lines       15786    15786           
=======================================
  Hits         9990     9990           
  Misses       5796     5796           

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move over looks good, shouldn't interrupt any of our current deck checking and recent extents work. Thanks Sanniti!

@sanni-t sanni-t merged commit 26da992 into edge Oct 9, 2024
21 checks passed
@sanni-t sanni-t deleted the api-move-pipette-movement-conflict branch October 9, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants