Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): update Step part design and export it as a component #16432

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 8, 2024

Overview

update Step part design and export it as a component

design
https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45/Feature%3A-Protocol-Designer-Phase-1?node-id=10084-348590&m=dev

after

Screenshot 2024-10-08 at 12 49 20 PM

close RQA-3291

Test Plan and Hands on Testing

Changelog

  • add StepsInfo component and its test
  • update ProtocolOverivew test

Review requests

Risk assessment

low

…mponent

update Step part design and export it as a component

close RQA-3291
@koji koji requested a review from ncdiehl11 October 8, 2024 16:52
@koji koji marked this pull request as ready for review October 8, 2024 16:52
@koji koji requested a review from a team as a code owner October 8, 2024 16:52
@koji koji added the authorship label Oct 8, 2024
@koji koji requested review from jerader and removed request for a team October 9, 2024 02:02
@koji koji requested a review from ncdiehl11 October 11, 2024 17:03
@ncdiehl11
Copy link
Collaborator

Apologies for my previous review: even for a protocol with no added steps, there is exactly one saved step form of type __INITIAL_DECK_SETUP_STEP__, so the check for savedStepForms.length <= 1 was correct. We can either leave this check, or filter out this step form type from savedStepForms and check length of 0. Either works. Thanks @koji !

@koji
Copy link
Contributor Author

koji commented Oct 11, 2024

Apologies for my previous review: even for a protocol with no added steps, there is exactly one saved step form of type __INITIAL_DECK_SETUP_STEP__, so the check for savedStepForms.length <= 1 was correct. We can either leave this check, or filter out this step form type from savedStepForms and check length of 0. Either works. Thanks @koji !

Thanks @ncdiehl11 !

@koji koji merged commit e261f04 into edge Oct 11, 2024
14 checks passed
@koji koji deleted the fix_RQA-3291 branch October 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants