fix(hardware): Ignore the Hepa/UV when resolving attached tools. #16175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Hepa/UV is not detected through the head attachment/detachment mechanism like the rest of the tools (pipettes, grippers, etc) since the device is not physically attached to the head, instead, it's connected via the second AUX port and detected on startup via a broadcast
DeviceInfoRequest
CAN message. Since we are using theToolDetectionResult
to resolve the attached Nodes (which does not include Hepa/UV right now), we are running into an infinite loop when comparing the expected nodes (pipettes, gripper) vs the seen nodes (pipettes, gripper, hepa_uv). So let's ignore the Hepa/UV when resolving the attached tools so we don't run into this issue, eventually we will want to add a resolving mechanism for the Hepa/UV.Related to: RQA-3064
This was found while looking into the above issue and could be causing problems related to whats being seen.
Test Plan and Hands on Testing
Changelog
Review requests
Makes sense?
Risk assessment
Low, does not change response.