Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): Ignore the Hepa/UV when resolving attached tools. #16175

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Aug 30, 2024

Overview

The Hepa/UV is not detected through the head attachment/detachment mechanism like the rest of the tools (pipettes, grippers, etc) since the device is not physically attached to the head, instead, it's connected via the second AUX port and detected on startup via a broadcast DeviceInfoRequest CAN message. Since we are using the ToolDetectionResult to resolve the attached Nodes (which does not include Hepa/UV right now), we are running into an infinite loop when comparing the expected nodes (pipettes, gripper) vs the seen nodes (pipettes, gripper, hepa_uv). So let's ignore the Hepa/UV when resolving the attached tools so we don't run into this issue, eventually we will want to add a resolving mechanism for the Hepa/UV.

Related to: RQA-3064
This was found while looking into the above issue and could be causing problems related to whats being seen.

Test Plan and Hands on Testing

  • Make sure that we don't run into an infinite loop when attaching/detaching instruments while the Hepa/UV is connected and powered on.

Changelog

  • Don't expect the Hepa/UV to respond when resolving attached tools

Review requests

Makes sense?

Risk assessment

Low, does not change response.

@vegano1 vegano1 requested a review from a team as a code owner August 30, 2024 20:23
@vegano1 vegano1 requested a review from sfoster1 August 30, 2024 20:24
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (chore_release-8.0.0@933175f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ntrons_hardware/hardware_control/tools/detector.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             chore_release-8.0.0   #16175   +/-   ##
======================================================
  Coverage                       ?   55.74%           
======================================================
  Files                          ?      113           
  Lines                          ?     9369           
  Branches                       ?        0           
======================================================
  Hits                           ?     5223           
  Misses                         ?     4146           
  Partials                       ?        0           
Flag Coverage Δ
hardware 55.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntrons_hardware/hardware_control/tools/detector.py 89.04% <0.00%> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vegano1 vegano1 merged commit 3cba451 into chore_release-8.0.0 Sep 3, 2024
13 of 15 checks passed
@vegano1 vegano1 deleted the ignore-hepa-uv-when-resolving-tools branch September 3, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants