refactor(robot-server): Interact with Paho from a single thread #16078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
changed the title
mjhuff
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Thank you for digging into this (and fixing some of my sloppier Python work)!
It's strange to me that the major MQTT library for Python doesn't document its publish behavior as well as we'd expect. From what I can tell, these changes are safe. I think merging this kind of networking stuff into edge as early as possible into the next dev cycle is the best move.
| """Intended to be used by endpoint functions as a FastAPI dependency.""" | ||
| notification_client = _notification_client_accessor.get_from(app_state) | ||
| assert ( |
TamarZanzouri
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-685. See that ticket for explanation.
Test Plan and Hands on Testing
Changelog
Review requests
Double-check my understanding of how Paho works. If I'm wrong about its
publish()method being non-blocking, this risks stalling all of robot-server. For example, if some Paho buffer fills up, robot-server will stop responding toGET /healthrequests until it's drained.Risk assessment
Low-ish, but see review requests.