Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to pull unique run logs from ABR robots #14553

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Script to pull unique run logs from ABR robots #14553

merged 4 commits into from
Feb 27, 2024

Conversation

rclarke0
Copy link
Contributor

Overview

This folder pulls run log information from each robot in ABR and saves them locally to your personal computer

Test Plan

Example Test Plan (HTTP API Change)

  • Pulled run logs from all ABR robots with and without robots running
  • Concluded that pulling while running slows the robots movements down but does not cause any failed runs to occur
  • Pulled multiple times in a row to ensure duplicate runs were not being added and new runs were not being missed

Changelog

  • Added ABR IP addresses
  • Added script to pull command, health, and protocol data using http requests with each ip address
  • saves runs with unique run ids

Review requests

N/A

Risk assessment

  • IP Addresses are now public to the internet

This script has more edits to be made:

  • if IP addresses on ABR robots change the script will need to be updated
  • Eventually the script will be edited so that it no longer saves to a local computer
  • Eventually the script will include more data extraction from the robot including: labware offsets per run, instrument serials per run, etc.

@rclarke0 rclarke0 requested a review from a team as a code owner February 27, 2024 15:58
@rclarke0 rclarke0 requested a review from sfoster1 February 27, 2024 15:58
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

print(
f"Saved {len(runs_to_save)} run(s) from robot {robot_name} with IP address {ip}."
)
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove the pass, not necessary anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

except Exception:
print(f"Failed to read IP address: {ip}.")
traceback.print_exc()
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove the pass, not necessary anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

@rclarke0 rclarke0 merged commit 8fd8a19 into edge Feb 27, 2024
6 checks passed
@rclarke0 rclarke0 deleted the ABR-Run-Logs branch February 27, 2024 21:22
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
# Overview

This folder pulls run log information from each robot in ABR and saves
them locally to your personal computer

# Test Plan

Example Test Plan (HTTP API Change)

- Pulled run logs from all ABR robots with and without robots running
- Concluded that pulling while running slows the robots movements down
but does not cause any failed runs to occur
- Pulled multiple times in a row to ensure duplicate runs were not being
added and new runs were not being missed

# Changelog

- Added ABR IP addresses
- Added script to pull command, health, and protocol data using http
requests with each ip address
- saves runs with unique run ids

# Review requests

N/A

# Risk assessment
- IP Addresses are now public to the internet

This script has more edits to be made:
- if IP addresses on ABR robots change the script will need to be
updated
- Eventually the script will be edited so that it no longer saves to a
local computer
- Eventually the script will include more data extraction from the robot
including: labware offsets per run, instrument serials per run, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants