Skip to content

Commit

Permalink
Revert jsonschema loosening.
Browse files Browse the repository at this point in the history
jsonschema>=4.18.1 causes $ref resolution errors in some JSON protocols, for reasons I haven't been able to discern.

The api test environment can't reproduce the problem because its Pipfile still pins it to 4.17. But the snapshot tests just do `pip install ../api`, which uses this setup.py file and installs the latest matching jsonschema, so those tests do catch the problem.

As far as I can tell, there is no reason to update jsonschema in this PR. This version constraint may have been loosened accidentally in an earlier commit. So let's just undo it.
  • Loading branch information
SyntaxColoring committed Dec 14, 2024
1 parent 93affa8 commit 2b4863c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion api/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def get_version():
f"opentrons-shared-data=={VERSION}",
"aionotify==0.3.1",
"anyio>=3.6.1,<4.0.0",
"jsonschema>=4.0.0,<5",
# todo(mm, 2024-12-14): investigate ref resolution problems caused by jsonschema>=4.18.1.
"jsonschema>=3.0.1,<4.18.0",
"numpy>=1.20.0,<2",
"pydantic>=2.0.0,<3",
"pydantic-settings>=2,<3",
Expand Down

0 comments on commit 2b4863c

Please sign in to comment.