-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin.getInstance #274
Conversation
@frangio Please feel free to suggest the proper naming and code structure. Thanks! |
4933dd8
to
2e55d8b
Compare
2e55d8b
to
0c8f474
Compare
Thanks @pinglamb! What is the reason for exposing it as a function (i.e. |
It seems that if it is an instance, once |
Yes that makes sense. I think the function name We have to add the same function in the Truffle plugin. The code is very similar. Can you do these changes? |
f32461b
to
e224ac6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pinglamb! I've changed the tests a little to give us more confidence that the return value is correct.
This PR is for kicking off #173.
An
deployedProxyAdmin
method is added toadmin
module to getProxyAdmin
instance (feel free to suggest names). My use case is simply to get the address programmatically withoutfs.readFileSync
the manifest.