Fix Hardhat compile error when overriding interface functions with public constant variables #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
When making modified solc input for extracting namespaced storage type information, we previously removed all function bodies and converted all functions' return parameters to
bool
s so that they can be default initialized.However, if a public constant variable overrides an interface function as in #1087, this causes a mismatch in return type because the interface function's return parameters were modified as above.
Instead, this PR does the following: