This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Initializable: moving initialized and initializing flags to memory slots #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to the implementation, which is stored at position 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc to avoid conflict with the memory space of the master contract, it would be interesting to store the initialization flags away fro the straight forward memory space.
This would allow proxies and masters to be "initialization aware" without having to share a common header and risking conflicts.
An example of usage would be in Kitsune Wallet's proxy base which has to
unlock()
(line 28) before re-initializating (during a migration). This unlock would be as simple as_setInitialized(false)
with the proposed implementation.