Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guides for 5.0 #4654

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Fix guides for 5.0 #4654

merged 4 commits into from
Oct 5, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Oct 5, 2023

Fixes various mentions of _beforeTokenTransfer, etc.

@frangio frangio requested a review from ernestognw October 5, 2023 00:40
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3523166

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw
ernestognw previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

test/token/ERC20/extensions/ERC4626.test.js Outdated Show resolved Hide resolved
test/token/ERC20/extensions/ERC4626.test.js Outdated Show resolved Hide resolved
@frangio frangio merged commit e12511b into OpenZeppelin:master Oct 5, 2023
@frangio frangio deleted the fix-guides-5.0 branch October 5, 2023 01:37
frangio added a commit that referenced this pull request Oct 5, 2023
@frangio
Fix guides for 5.0 (#4654)
bd25a0a 
Co-authored-by: Ernesto García <[email protected]>
(cherry picked from commit e12511b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frangio @ernestognw