Enable ERC-1271 signature checks in Governor castVoteBySig
#4418
Conversation
🦋 Changeset detectedLatest commit: 3b9dcd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.changeset/popular-deers-raise.md
Outdated
| 'openzeppelin-solidity': major | ||
| --- | ||
|
|
||
| `Governor`: Use `bytes memory` signature instead of `r`, `s` and `v` parameters in the `castVoteBySig` and `castVoteWithReasonAndParamsBySig` functions |
There was a problem hiding this comment.
Why not merge the two changesets into one?
There was a problem hiding this comment.
I just thought both required their own entry. Although the main reason of this PR is to introduce 1271 compatibility, it requires this change that should be communicated on its own.
We can think of an individual changeset if you think it's needed
There was a problem hiding this comment.
My intuition is that all of the changes to castVoteBySig should be together in the same changeset, including also #4378 currently in .changeset/sixty-numbers-reply.md.
If not that, I do think we should at least merge the 2 in this PR.
There was a problem hiding this comment.
I prefer merging these two into a single one because otherwise, we'll be breaking the PR reference when processing the changesets into the changelog.
Not sure if all the changes should be in a single entry. But I'd be worried about the order in the Changelog once they get processed.
|
Can we quickly look at how much it increases deployment cost to add an overload of |
Co-authored-by: Hadrien Croubois <[email protected]> Co-authored-by: Francisco <[email protected]>
Co-authored-by: Francisco <[email protected]>
Sure, these are the results ( diff --git a/.gas b/.gas
index cd6f167d..42f6269f 100644
--- a/.gas
+++ b/.gas
@@ -9,25 +9,25 @@
························|································································|·············|·············|·············|···············|··············
| $VotesMock · $_mint(address,uint256) · 62741 · 141566 · 85268 · 30 · - │
························|································································|·············|·············|·············|···············|··············
-| $VotesMock · delegate(address,address) · 81745 · 96110 · 92513 · 4 · - │
+| $VotesMock · delegate(address,address) · 81723 · 96088 · 92491 · 4 · - │
························|································································|·············|·············|·············|···············|··············
-| $VotesMock · delegate(address) · 48371 · 111409 · 71138 · 9 · - │
+| $VotesMock · delegate(address) · 48349 · 111387 · 71116 · 9 · - │
························|································································|·············|·············|·············|···············|··············
-| $VotesMock · delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) · 76778 · 124056 · 92537 · 3 · - │
+| $VotesMock · delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) · 76745 · 124035 · 92512 · 3 · - │
························|································································|·············|·············|·············|···············|··············
| $VotesTimestampMock · $_burn(address,uint256) · 95539 · 95623 · 95567 · 3 · - │
························|································································|·············|·············|·············|···············|··············
| $VotesTimestampMock · $_mint(address,uint256) · 62650 · 141384 · 85164 · 30 · - │
························|································································|·············|·············|·············|···············|··············
-| $VotesTimestampMock · delegate(address,address) · 81654 · 96019 · 92422 · 4 · - │
+| $VotesTimestampMock · delegate(address,address) · 81632 · 95997 · 92400 · 4 · - │
························|································································|·············|·············|·············|···············|··············
-| $VotesTimestampMock · delegate(address) · 48371 · 111227 · 71088 · 9 · - │
+| $VotesTimestampMock · delegate(address) · 48349 · 111205 · 71066 · 9 · - │
························|································································|·············|·············|·············|···············|··············
-| $VotesTimestampMock · delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) · 76778 · 123965 · 92507 · 3 · - │
+| $VotesTimestampMock · delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) · 76757 · 123944 · 92486 · 3 · - │
························|································································|·············|·············|·············|···············|··············
| Deployments · · % of limit · │
·························································································|·············|·············|·············|···············|··············
-| $VotesMock · - · - · 1571033 · 15.7 % · - │
+| $VotesMock · - · - · 1783636 · 17.8 % · - │
·························································································|·············|·············|·············|···············|··············
-| $VotesTimestampMock · - · - · 1534941 · 15.3 % · - │
+| $VotesTimestampMock · - · - · 1747531 · 17.5 % · - │
·----------------------------------------------------------------------------------------|-------------|-------------|-------------|---------------|-------------· |
|
LGTM. We can discuss |
Fixes LIB-954
PR Checklist
npx changeset add)