Change behavior of ceilDiv(0, 0) and improve test coverage #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c02d6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
frangio
changed the title
frangio
approved these changes
Jun 14, 2023
72 tasks
Amxx
reviewed
Jun 15, 2023
| 'openzeppelin-solidity': minor | ||
| --- | ||
|
|
||
| `Math`: Make `ceilDiv` to revert on 0 division even if the numerator is 0 |
There was a problem hiding this comment.
Its actually a panic. But this is already merge so whatever.
There was a problem hiding this comment.
I think the changeset is correct, it reverts with a Panic error.
|
FYI, I got a question here 2477534#r118328369. |
This was referenced Sep 10, 2024
This was referenced Sep 11, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses last pending comment in #4261 about testing coverage.
I fixed some uncovered branches but is difficult to check for exhaustivity, and also some new added branches are difficult to reach specially because they're errors.