-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IERC5313.sol #4013
Add IERC5313.sol #4013
Conversation
🦋 Changeset detectedLatest commit: d036a21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@frangio Do we want the
|
It's already modified, we're not keeping the Solidity version and LICENSE. I know it's a minor detail but since we're doing that, why not keep our doc slightly more explicit? |
I don't think we need interfaces to be copied exactly from the EIPs. We can definitely improve the documentation. |
It doesn't really make any difference does it? Either way is fine with me.
Yes I think so. By the way, that may be a good name rather than |
Co-authored-by: Ernesto García <[email protected]>
Upstream Foundry/Solidity error in foundry tests. |
EIP is final: https://eips.ethereum.org/EIPS/eip-5313
Should we inherit that in
Ownable
?AccessControlAdmin
?PR Checklist
npx changeset add
)