Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some NatSpec and revert reasons #3809

Merged
merged 12 commits into from
Nov 25, 2022

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Nov 10, 2022

Assorted suggestions arising from an internal audit.

@frangio frangio marked this pull request as ready for review November 16, 2022 02:56
@frangio frangio changed the title Improve some NatSpec, revert reasons, code ordering Improve some NatSpec and revert reasons Nov 16, 2022
Copy link
Contributor

@JulissaDantes JulissaDantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the Checkpoint tests since they expect a different revert reasons.

contracts/token/ERC20/extensions/ERC4626.sol Show resolved Hide resolved
@frangio frangio merged commit 8f8fd84 into OpenZeppelin:master Nov 25, 2022
@frangio frangio deleted the minor-fixes-20221109 branch November 25, 2022 15:55
frangio added a commit that referenced this pull request Nov 25, 2022
Co-authored-by: JulissaDantes <[email protected]>
(cherry picked from commit 8f8fd84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants