Simplify ERC721 revert reasons #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure "token ID not minted" is the right message here. A token that has been minted and then burned doesn't exist anymore. IMO "token ID not minted" can be interpreted as "the ID was not minted" which in that case would be wrong. |
|
Would you suggest another phrase? I agree that the message is not strictly precise in the sense that you describe, but I think it's an improvement over the current ones. I don't see it as serious that a burned token then says "not minted". |
|
I still prefer "nonexistent token ID" or "invalid token ID" |
Amxx
previously approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a helper to check that a token ID is minted / exists.