Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding of ERC1155 functions #2263

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Allow overriding of ERC1155 functions #2263

merged 2 commits into from
Jun 2, 2020

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Jun 2, 2020 •
edited
Loading

Following #2162, this PR changes some external ERC1155 functions to public so that they can be properly overridden.

It also removes some internals from the API (like #2134 did).

@nventuro nventuro requested a review from frangio June 2, 2020 16:30
frangio
frangio approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nventuro nventuro merged commit 91516b2 into OpenZeppelin:master Jun 2, 2020
@nventuro nventuro deleted the erc1155-virtual branch June 2, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio