Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SafeERC20.safeApprove #2220

Closed
wants to merge 2 commits into from
Closed

Fix SafeERC20.safeApprove #2220

wants to merge 2 commits into from

Conversation

BrendanChou
Copy link
Contributor

Fixes #2219

@BrendanChou BrendanChou changed the title Update SafeERC20.sol Fix SafeERC20.safeApprove Apr 29, 2020
@stale
Copy link

stale bot commented May 29, 2020

Hi all!
This Pull Request has not had any recent activity, is it still relevant? If so, what is blocking it? Is there anything we can do to help move it forward?
Thanks!

@stale stale bot added the stale label May 29, 2020
@nventuro
Copy link
Contributor

nventuro commented Jun 5, 2020

Closing in favor of #2268 as per the discussion in #2219. Thank you very much for your help @BrendanChou!

@stale stale bot removed the stale label Jun 5, 2020
@nventuro nventuro closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SafeERC20.safeApprove() Has unnecessary and unsecure added behavior
2 participants
@BrendanChou @nventuro