API improvements for EnumerableSet #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the interest of speed I ended up also doing some internal renaming (values -> keys) on this PR, so that it can be used to build on top of when working on #2072. Sorry if you find this too messy. Reviewing commit by commit should be fine though. |
|
This ended up being a mish-mash of unrelated improvements. After experimenting with |
frangio
reviewed
Mar 27, 2020
nventuro
changed the title
frangio
reviewed
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code did error-out on out of bounds accesses, but with an invalid opcode instead of a proper revert reason.