Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of Ownership directory #2120

Merged
merged 11 commits into from
Mar 16, 2020
Merged

Cleanup of Ownership directory #2120

merged 11 commits into from
Mar 16, 2020

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Mar 12, 2020 •
edited
Loading

Part of #2060.

This PR is probably better reviewed commit by commit. It does the following:

  • Remove Ownable.isOwner, an oddity of the library: a view function that uses msg.sender
  • Remove Secondary from the library
  • Replace all uses of Secondary for Ownable
  • Move Ownable to the access directory
  • Remove the ownership directory

I set up docsite redirects in OpenZeppelin/docs.openzeppelin.com#159

@nventuro nventuro requested a review from frangio March 12, 2020 16:10
@nventuro nventuro mentioned this pull request Mar 12, 2020
Merged
frangio
frangio previously approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/mocks/OwnableInterfaceId.sol Outdated Show resolved Hide resolved
@nventuro nventuro merged commit 8176a90 into OpenZeppelin:master Mar 16, 2020
@nventuro nventuro deleted the ownership-cleanup branch March 16, 2020 18:12
@nventuro nventuro mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio