Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Counter.sol #1914

Closed
wants to merge 1 commit into from
Closed

Conversation

AjiteshBD
Copy link
Contributor

Updated increment function replaced "+" operator with safemath add function.

Fixes #

Updated increment function replaced "+" operator  with safemath add function.
@nventuro
Copy link
Contributor

Hello @AjiteshBD, thanks for opening this PR!

We actually explicitly decided to not use SafeMath here, see the discussion in #1552 (comment), and the comment at the top of the Counter library. Perhaps we should also add a comment in add to make this more visible?

Thanks again for taking the time to contribute!

@nventuro nventuro closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants