Moved Escrows into an escrow subdirectory, improved docs. #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-maiz
previously approved these changes
Oct 17, 2018
| @@ -2,7 +2,7 @@ pragma solidity ^0.4.24; | |||
|
|
|||
| import "../../math/SafeMath.sol"; | |||
| import "./FinalizableCrowdsale.sol"; | |||
| import "../../payment/RefundEscrow.sol"; | |||
| import "../../payment/escrow/RefundEscrow.sol"; | |||
There was a problem hiding this comment.
I'm not super comfortable with the hierarchy of directories. But ok, this is not going deeper than what we have in crowdsales or token, so +1 with reservations.
There was a problem hiding this comment.
Don't worry, I won't let this become Java!
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* Moved Escrows into an escrow subdirectory, improved docs. * Fixed escrow mock. * Fixed some more imports. (cherry picked from commit f3df2da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @cwhinfrey for the docstrings writeup!