Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added address of pauser/unpauser in events #1410

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Added address of pauser/unpauser in events #1410

merged 2 commits into from
Oct 18, 2018

Conversation

Glisch
Copy link
Contributor

@Glisch Glisch commented Oct 12, 2018

Fixes #1393

Added address of the caller for Paused and Unpaused events in Pausable.sol

@nventuro nventuro self-assigned this Oct 12, 2018
@nventuro nventuro added this to the v2.0 milestone Oct 12, 2018
@nventuro
Copy link
Contributor

Great @Glisch, thanks for contributing to OpenZeppelin!

Could you also add this address when checking the events in the Pausable tests?

@Glisch
Copy link
Contributor Author

Glisch commented Oct 12, 2018

Oops, sure thing.

@nventuro
Copy link
Contributor

Sorry to push directly to your branch @Glisch, but we're planning on wrapping up the 2.0 release for tomorrow morning, and need to get this in before then. Thanks a lot for your help!

@nventuro nventuro requested a review from come-maiz October 17, 2018 21:22
Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Glisch and @nventuro! <3

@nventuro nventuro merged commit fcab9c8 into OpenZeppelin:master Oct 18, 2018
come-maiz pushed a commit that referenced this pull request Oct 21, 2018
* Added address of pauser/unpauser in events

* Added the account to the Pausable tests.

(cherry picked from commit fcab9c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Pausable events
3 participants