Separate ERC721Mintable #1365
Merged
Separate ERC721Mintable #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
added
feature
frangio
force-pushed
the
721-metadata-mintable
branch
from
758ae20 to
dc28c9a
Compare
frangio
force-pushed
the
721-metadata-mintable
branch
from
dc28c9a to
d10add4
Compare
nventuro
reviewed
Oct 1, 2018
|
|
||
|
|
||
| /** | ||
| * @title ERC721Mintable |
There was a problem hiding this comment.
This should now read ERC721MetadataMintable
| @@ -1,13 +1,13 @@ | |||
| pragma solidity ^0.4.24; | |||
|
|
|||
| import "./ERC721Full.sol"; | |||
| import "./ERC721Metadata.sol"; | |||
There was a problem hiding this comment.
Shouldn't this be ERC721?
contracts/mocks/ERC721FullMock.sol
Outdated
| @@ -2,14 +2,15 @@ pragma solidity ^0.4.24; | |||
|
|
|||
| import "../token/ERC721/ERC721Full.sol"; | |||
| import "../token/ERC721/ERC721Mintable.sol"; | |||
| import "../token/ERC721/ERC721MetadataMintable.sol"; | |||
| import "../token/ERC721/ERC721Burnable.sol"; | |||
|
|
|||
| /** | |||
| * @title ERC721Mock | |||
There was a problem hiding this comment.
This is now ERC721FullMock
|
@nventuro I got coverage back up at 100%. There were two tests testing the wrong thing. |
nventuro
pushed a commit
that referenced
this pull request
Oct 4, 2018
* separate part of ERC721Mintable into ERC721MetadataMintable * remove mint and burn from 721 tests * Fixed linter error. * fix ERC721 mint tests * Minor fixes. (cherry picked from commit 744f567)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have only one
ERC721Mintablethat required to be plugged into anERC721Full. This change allows making a more minimalERC721mintable.