Changes to Counter #1332
Merged
Changes to Counter #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
added a commit
to frangio/openzeppelin-contracts
that referenced
this pull request
Sep 18, 2018
* rename Index.currentId to current * use += operator for clarity * rename Counter.Index to Counter.Counter * move Counter to drafts (cherry picked from commit 3e55408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
Counter.IndextoCounter.Counter, and moves the file todrafts. I'm moving it because we don't really have consensus about this name (see #1307), and the library isn't used elsewhere in OpenZeppelin either, so its design might change based on the needs we discover when we use it in the future.